Stricter caching for imgpkg bundles#401
Open
100mik wants to merge 1 commit intocarvel-dev:developfrom
Open
Conversation
… reference rather than just digest Signed-off-by: Soumik Majumder <soumikm@vmware.com>
100mik
force-pushed
the
100mik/stricter-caching
branch
from
af0008f to
c706c80
Compare
Contributor
Author
|
Confirmed that we will still only be caching artifacts with digest references as |
praveenrewar
reviewed
Oct 9, 2024
Member
praveenrewar
left a comment
praveenrewar
left a comment
There was a problem hiding this comment.
It would be good to have a test added for this.
joaopapereira
requested changes
Oct 9, 2024
Member
joaopapereira
left a comment
joaopapereira
left a comment
There was a problem hiding this comment.
THe change looks good, but I agree with @praveenrewar we should have a test to ensure the behavior is what we expect
Member
|
@100mik any update on this? |
Member
|
@100mik do you think you can add some tests to ensure that we will not have regressions in the future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a fully-qualified reference as key for a cache rather than the digest.
Resolves #399 and eventually carvel-dev/kapp-controller#1603