fix(git): optimize fetch to selectively include tags and checkout exct#433
Open
corydolphin wants to merge 2 commits intocarvel-dev:developfrom
Open
fix(git): optimize fetch to selectively include tags and checkout exct#433corydolphin wants to merge 2 commits intocarvel-dev:developfrom
corydolphin wants to merge 2 commits intocarvel-dev:developfrom
Conversation
…ct refs - Disabled unconditional addition of "remote.origin.tagOpt" config; only add if not fetching exact ref - Introduced exactRef flag to detect when fetching a specific origin ref - When fetching exact ref, checkout uses "FETCH_HEAD" instead of the ref name to avoid detached head advice - Cleaned up commented-out code and improved fetch argument logic accordingly Signed-off-by: Filip Pytloun <filip@pytloun.cz>
Signed-off-by: Cory Dolphin <cory@nextdoor.com>
|
Thank you @corydolphin, I did not have time to work on my PR further. |
Author
|
Hey @joaopapereira are you open to taking a look at this change? It would be a great win for many of your git users. Regardless, thank you for the work! |
joaopapereira
requested changes
Feb 3, 2026
Member
joaopapereira
left a comment
joaopapereira
left a comment
There was a problem hiding this comment.
I would love to have some tests for this to ensure that we are not breaking things in the future.
Do you think you can add them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #427 simply with an additional stacked diff to address lint failures.
Hello,
I've enjoyed using this tool and would benefit from @fpytloun's tag fetching changes. I've made a quick change to hopefully fix the lint errors, and it seems to pass all tests locally.
I don't seem to be able to more easily stack these changes with a PR on top of @fpytloun's work, so this is a new PR.
Thank you,
Cory