Testing : Fix semver comparision issue#439
Open
sameerforge wants to merge 1 commit intocarvel-dev:developfrom
Open
Testing : Fix semver comparision issue#439sameerforge wants to merge 1 commit intocarvel-dev:developfrom
sameerforge wants to merge 1 commit intocarvel-dev:developfrom
Conversation
sameerforge
changed the title
sameerforge
force-pushed
the
topic/sameerkh/fix_semver_comparision
branch
2 times, most recently
from
3158910 to
cd80472
Compare
Signed-off-by: Sameer <sameer.khan@broadcom.com>
sameerforge
force-pushed
the
topic/sameerkh/fix_semver_comparision
branch
from
cd80472 to
4d6c026
Compare
joaopapereira
requested changes
Feb 3, 2026
Member
joaopapereira
left a comment
joaopapereira
left a comment
There was a problem hiding this comment.
hmm, This feel more like an LT problem for the Semver library more than this function in particular. We should open PR to fix that library.
Also this is cause breaking backward compatibility because this part of the code as not been changed in a very long time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.