fix: use EMAIL_FROM as primary sender address instead of EMAIL_SMTP_USER#4
Open
Zielgestalt wants to merge 1 commit into
Open
fix: use EMAIL_FROM as primary sender address instead of EMAIL_SMTP_USER#4Zielgestalt wants to merge 1 commit into
Zielgestalt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fromEmail config currently defaults to EMAIL_SMTP_USER, which is the SMTP login credential - not necessarily a valid sender address.
With some email services (e.g. Brevo), the SMTP username is completely different from the actual sender address (e.g. no-reply@example.com).
This change adds EMAIL_FROM as the first option in the fallback chain:
EMAIL_FROM → EMAIL_SMTP_USER → default