feat: fix error "invalid request size"#168
Merged
hsluoyz merged 1 commit intocasbin:masterfrom Feb 5, 2026
Merged
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #152 where creating multiple enforcer instances with different request definitions causes an "invalid request size" error. The root cause was that the Model:new() constructor was incorrectly setting instance properties on the class (self) instead of on the instance (o), causing all Model instances to share the same class-level properties.
Changes:
- Fixed Model initialization to use instance-level properties instead of class-level properties
- Added regression test for creating multiple enforcers with distinct request definitions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/model/Model.lua | Fixed Model:new() to properly initialize instance properties (o.model, o.sectionNameMap, etc.) instead of class properties (self.model, self.sectionNameMap, etc.) |
| tests/main/enforcer_spec.lua | Added regression test that creates two enforcers with different request definitions and validates both work independently without interfering with each other |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsluoyz
changed the title
|
🎉 This PR is included in version 1.46.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #152
I have been affected by isssue #152 and tracked it down to an initialization error in the model instance. I propose a patch with a regression test for your consideration. Thanks!