Add windows-script-interpreter setting#2944
Open
cspotcode wants to merge 2 commits intocasey:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed here: #2260 (comment)
I did my best to copy coding conventions from
windows-shell, but I'm not a rust expert.Worth noting that, although this does solve my use-case -- pointing to a different
shon Windows than Linux -- it doesn't let you[script('linux-shell')]and[windows-script('windows-shell')]. If you're specifying shell inline within the attribute, you can't specify a different option for Windows and Linux. For that, you're still better off using#!{{SHEBANG}}and setting that variable conditionally.Tests are failing locally for me, but I suspect that's because my
bash.exeis WSL2, but tests try to use it as a Windows bash shell. I'm opening this PR to get some initial feedback; don't want to waste time fixing my local testing issue if this PR can't be merged for other reasons.