fix: Binary naming for harness#54
Conversation
Kimchi Code Review
Summary📊 Review Score: 98/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: yes — All test files ( No significant issues found. LGTM! 🎉 What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 98/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 1/5 (1 = trivial, 5 = very complex)
🧪 Tests: yes — All test files (extract_test.go, harness_test.go, workflow_test.go) are updated to use the new binary name kimchi instead of kimchi-code, ensuring test expectations match the implementation changes in github_client.go.
No significant issues found. LGTM! 🎉
Kimchi Summary
What changed
Aligns the development harness binary name with the main binary by renaming references from
kimchi-codetokimchithroughout the update system.Why
The
kimchi-devrepository now publishes its binary askimchirather thankimchi-code, requiring the update client to look for the correct filename when downloading and extracting releases.Key changes
internal/update/github_client.go: UpdatedkimchiDevRepo.Binaryconstant from"kimchi-code"to"kimchi"internal/update/harness.go: Updated documentation comment to reference the correct binary nameinternal/update/extract_test.go: Modified test archive contents and assertions to expectbin/kimchiinstead ofbin/kimchi-codeinternal/update/harness_test.go: Updated path resolution tests and fixtures to usekimchibinary nameinternal/update/workflow_test.go: Updated test package JSON metadata to use"kimchi"as the name value