Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

fix: Binary naming for harness#54

Merged
igor-susic1 merged 1 commit into
mainfrom
fix-kimchi-harness-naming-binary
May 5, 2026
Merged

fix: Binary naming for harness#54
igor-susic1 merged 1 commit into
mainfrom
fix-kimchi-harness-naming-binary

Conversation

@igor-susic1
Copy link
Copy Markdown
Contributor

@igor-susic1 igor-susic1 commented May 5, 2026


Kimchi Summary

What changed

Aligns the development harness binary name with the main binary by renaming references from kimchi-code to kimchi throughout the update system.

Why

The kimchi-dev repository now publishes its binary as kimchi rather than kimchi-code, requiring the update client to look for the correct filename when downloading and extracting releases.

Key changes

  • internal/update/github_client.go: Updated kimchiDevRepo.Binary constant from "kimchi-code" to "kimchi"
  • internal/update/harness.go: Updated documentation comment to reference the correct binary name
  • internal/update/extract_test.go: Modified test archive contents and assertions to expect bin/kimchi instead of bin/kimchi-code
  • internal/update/harness_test.go: Updated path resolution tests and fixtures to use kimchi binary name
  • internal/update/workflow_test.go: Updated test package JSON metadata to use "kimchi" as the name value

@kimchi-review
Copy link
Copy Markdown

kimchi-review Bot commented May 5, 2026

Kimchi Code Review

Property Value
Commit 4f5af88
Author @igor-susic1
Files changed 0
Review status Completed
Comments 0
Duration 15s

Summary

📊 Review Score: 98/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 1/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — All test files (extract_test.go, harness_test.go, workflow_test.go) are updated to use the new binary name kimchi instead of kimchi-code, ensuring test expectations match the implementation changes in github_client.go.

No significant issues found. LGTM! 🎉

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @kimchi review — re-trigger a full review on the latest commit
  • @kimchi summary — regenerate the PR summary
  • @kimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

Copy link
Copy Markdown

@kimchi-review kimchi-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 98/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 1/5 (1 = trivial, 5 = very complex)

🧪 Tests: yes — All test files (extract_test.go, harness_test.go, workflow_test.go) are updated to use the new binary name kimchi instead of kimchi-code, ensuring test expectations match the implementation changes in github_client.go.

No significant issues found. LGTM! 🎉

@igor-susic1 igor-susic1 merged commit 1c36f19 into main May 5, 2026
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants