LLM-1387: remove deprecation warning#58
Conversation
Kimchi Code Review
Summary📊 Review Score: 95/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: no — No tests were added or modified for this change. The removal of deprecation warning messaging and color variables in the bash script does not include accompanying test updates. No significant issues found. LGTM! 🎉 What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 95/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 1/5 (1 = trivial, 5 = very complex)
🧪 Tests: no — No tests were added or modified for this change. The removal of deprecation warning messaging and color variables in the bash script does not include accompanying test updates.
No significant issues found. LGTM! 🎉
Kimchi Summary
What changed
Removes the CLI deprecation warnings from
scripts/install.sh. The script continues to redirect users to thekimchi-devinstaller but no longer displays the yellow warning banner or blue redirect notice.Key changes
scripts/install.sh: Removed color code variables (YELLOW,BLUE,NC) andechostatements that printed the deprecation warning. Theexec bashredirect to thekimchi-devrelease remains unchanged.Impact
Users executing the install script will no longer see deprecation warnings before being redirected to the new installer.