Upgrade to .net 4.0 and NHibernate 4#4
Open
xumix wants to merge 6 commits intocastleproject-deprecated:masterfrom
Open
Upgrade to .net 4.0 and NHibernate 4#4xumix wants to merge 6 commits intocastleproject-deprecated:masterfrom
xumix wants to merge 6 commits intocastleproject-deprecated:masterfrom
Conversation
Member
|
Thanks for your contribution. Can you please revert your formatting only changes (e.g. changing tabs to space) as they don't match the Castle conventions. |
Author
|
Done converting to tabs, that's all I can do |
Member
|
Thanks for fixing the tabs problem, however you've also reformatted every file you've touched, I can't sanely review 5000+ lines changed. Once that is sorted I should have a chance at reviewing it to point out things like one file with the Castle license header replaced with your own company ("Itopcase") copyright file header. |
|
+1 on that PR please merge it with master as soon as possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subj
all tests except 1 pass