Fix signatureHelp bug that has existed in Solargraph since version 0.54.1:#1185
Open
meilinxiaoxue wants to merge 1 commit intocastwide:masterfrom
Open
Fix signatureHelp bug that has existed in Solargraph since version 0.54.1:#1185meilinxiaoxue wants to merge 1 commit intocastwide:masterfrom
meilinxiaoxue wants to merge 1 commit intocastwide:masterfrom
Conversation
When autocompleting a function and typing a parenthesis triggers signatureHelp, the feature fails (no signatureHelp is shown) because the parenthesis is not closed. After the fix, signatureHelp should be displayed even when the parenthesis is not closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When autocompleting a function and typing a parenthesis triggers signatureHelp, the feature fails (no signatureHelp is shown) because the parenthesis is not closed.
for example:
In gvim ,use solargraph via coc-nvim and coc-solargraph("^"represent cursor location):
foo(^ //no signature help shows
foo(^) //signature shows
After the fix, signatureHelp should be displayed even when the parenthesis is not closed.