Fix redis_store->get function return type#863
Open
geichelberger wants to merge 1 commit intocatalyst:MOODLE_500_STABLEfrom
Open
Fix redis_store->get function return type#863geichelberger wants to merge 1 commit intocatalyst:MOODLE_500_STABLEfrom
geichelberger wants to merge 1 commit intocatalyst:MOODLE_500_STABLEfrom
Conversation
Return type declaration must be compatible with StoreInterface->get(type: string, key: string) : mixed
geichelberger
changed the title
geichelberger
changed the base branch from
MOODLE_404_STABLE
to
MOODLE_500_STABLE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redis_store->get function is incompatible with the StoreInterface->get function, which causes an exception while trying to log in.