Allow IdP to have separate config settings including field mappings#902
Open
danmarsden wants to merge 2 commits intoMOODLE_500_STABLEfrom
Open
Allow IdP to have separate config settings including field mappings#902danmarsden wants to merge 2 commits intoMOODLE_500_STABLEfrom
danmarsden wants to merge 2 commits intoMOODLE_500_STABLEfrom
Conversation
Member
Author
|
not ready for merging yet - currently reviewing and testing. |
Member
Author
|
@sarahjcotton @jacdsouza - do you guys have any modified versions of this one? - it seems to be failing unit tests for me with errors like the following: (github actions isn't triggering here, but possibly due to the 5.0 branch being tested.) |
|
Hey @danmarsden we haven't yet but it's in our Dev pipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebased version of #804