Skip to content

[T19] Fix tests and replace deprecated utf8_encode() function #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tatiana-gl wants to merge 1 commit into
base: TOTARA_19_STABLE
Choose a base branch
from
Open

[T19] Fix tests and replace deprecated utf8_encode() function #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/email_certificate_task_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,11 @@ public function test_email_certificates_teachers() {
// Confirm that we only sent out 2 emails, both emails to the teacher for the two students.
$this->assertCount(2, $emails);

$this->assertStringContainsString(fullname($user3), utf8_encode($emails[0]->header));
$this->assertStringContainsString(fullname($user3), mb_convert_encoding($emails[0]->header, 'UTF-8', 'ISO-8859-1'));
$this->assertEquals($CFG->noreplyaddress, $emails[0]->from);
$this->assertEquals($user3->email, $emails[0]->to);

$this->assertStringContainsString(fullname($user3), utf8_encode($emails[1]->header));
$this->assertStringContainsString(fullname($user3), mb_convert_encoding($emails[1]->header, 'UTF-8', 'ISO-8859-1'));
$this->assertEquals($CFG->noreplyaddress, $emails[1]->from);
$this->assertEquals($user3->email, $emails[1]->to);
}
Expand Down Expand Up @@ -189,11 +189,11 @@ public function test_email_certificates_others() {
// Confirm that we only sent out 2 emails, both emails to the other address that was valid for the two students.
$this->assertCount(2, $emails);

$this->assertStringContainsString(fullname(get_admin()), utf8_encode($emails[0]->header));
$this->assertStringContainsString(fullname(get_admin()), mb_convert_encoding($emails[0]->header, 'UTF-8', 'ISO-8859-1'));
$this->assertEquals($CFG->noreplyaddress, $emails[0]->from);
$this->assertEquals('testcustomcert@example.com', $emails[0]->to);

$this->assertStringContainsString(fullname(get_admin()), utf8_encode($emails[1]->header));
$this->assertStringContainsString(fullname(get_admin()), mb_convert_encoding($emails[1]->header, 'UTF-8', 'ISO-8859-1'));
$this->assertEquals($CFG->noreplyaddress, $emails[1]->from);
$this->assertEquals('testcustomcert@example.com', $emails[1]->to);
}
Expand Down