issue#14 exclude module types from the back up - #20
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds per-course “excluded_mods” support so specific activity module types can be omitted from generated course backups, wiring the value from CSV upload through storage, backup execution, UI display, and privacy export.
Changes:
- Add
excluded_modscolumn to the plugin DB schema (install + upgrade) and model property. - Parse optional
excluded_modsfrom uploaded CSV rows and display it in the migration table. - Apply module-level exclusions during backup plan execution and extend automated tests/docs accordingly.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.php | Bumps plugin version for the schema/code change. |
| db/upgrade.php | Adds excluded_mods field on upgrade savepoint. |
| db/install.xml | Adds excluded_mods field to fresh installs (but VERSION needs correction). |
| classes/coursemigration.php | Registers excluded_mods as a nullable text property. |
| classes/upload_course_list.php | Supports optional excluded_mods column in CSV processing. |
| classes/task/course_backup.php | Skips specified activity types when building the backup plan. |
| classes/output/coursemigration_table.php | Adds excluded_mods column to admin table output. |
| classes/privacy/provider.php | Includes excluded_mods in exported user data metadata and export. |
| lang/en/tool_coursemigration.php | Adds UI/help/privacy strings for excluded_mods. |
| README.md | Documents the new excluded_mods CSV feature (minor grammar issue). |
| example.csv | Updates sample CSV to include excluded_mods. |
| tests/upload_course_list_test.php | Extends CSV upload tests to validate excluded_mods persistence. |
| tests/task/course_backup_test.php | Adds backup-content assertions to verify excluded modules aren’t backed up (one test name typo). |
| tests/privacy/provider_test.php | Updates privacy export test coverage for the new field. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tuanngocnguyen
marked this pull request as draft
August 10, 2026 06:44
tuanngocnguyen
marked this pull request as ready for review
August 10, 2026 06:57
Author
|
Hi @dmitriim , Would you please review once you got time? |
Member
|
@tuanngocnguyen can you please have a look at failing CI? |
tuanngocnguyen
force-pushed
the
issue#14_main
branch
17 times, most recently
from
August 13, 2026 01:56
fddf075 to
c0395fa
Compare
tuanngocnguyen
force-pushed
the
issue#14_main
branch
2 times, most recently
from
August 13, 2026 02:41
b38a1f6 to
e805979
Compare
tuanngocnguyen
force-pushed
the
issue#14_main
branch
from
August 13, 2026 02:42
e805979 to
244e401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.