Skip to content

Get config from Moodle to set token cookie #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prinhelmet wants to merge 1 commit into
base: MOODLE_400_STABLE
Choose a base branch
from
Open

Get config from Moodle to set token cookie #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion factor/token/classes/factor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,9 @@ public function post_pass_state() {
$secretmanager->create_secret($expiry, false, $secret);

// All the prep is now done, we can set this cookie.
setcookie($cookie, $secret, $expirytime, $CFG->sessioncookiepath, $CFG->sessioncookiedomain, false, true);
$cookiesecure = 1 == get_config('core', 'cookiesecure');
$cookiehttponly = 1 == get_config('core', 'cookiehttponly');
setcookie($cookie, $secret, $expirytime, $CFG->sessioncookiepath, $CFG->sessioncookiedomain, $cookiesecure, $cookiehttponly);

// Finally emit a log event for storing the cookie.
$state = [
Expand Down