Skip to content

bypass mfa for enrolment #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
golenkovm merged 1 commit into from
Apr 16, 2025
Merged

bypass mfa for enrolment #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions classes/manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,12 +463,6 @@ public static function should_require_mfa($url, $preventredirect) {
return self::NO_REDIRECT;
}

// Enrolment.
$enrol = new \moodle_url('/enrol/index.php');
if ($enrol->compare($url, URL_MATCH_BASE)) {
return self::NO_REDIRECT;
}

// Guest access.
if (isguestuser()) {
return self::NO_REDIRECT;
Expand Down
5 changes: 0 additions & 5 deletions tests/manager_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,6 @@ public function test_should_require_mfa_checks() {
$this->assertEquals(\tool_mfa\manager::should_require_mfa($badurl, false), \tool_mfa\manager::NO_REDIRECT);
$this->setUser($user);

// Enrolment.
$enrolurl = new \moodle_url('/enrol/index.php');
$this->assertEquals(\tool_mfa\manager::should_require_mfa($badurl, false), \tool_mfa\manager::REDIRECT);
$this->assertEquals(\tool_mfa\manager::should_require_mfa($enrolurl, false), \tool_mfa\manager::NO_REDIRECT);

// Guest User.
$this->assertEquals(\tool_mfa\manager::should_require_mfa($badurl, false), \tool_mfa\manager::REDIRECT);
$this->setGuestUser();
Expand Down