🐛 Clang on Windows will define _MSC_VER and do a redefined-#define
#3060
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake it actually Visual C++-specific
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3060 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 202 202
Lines 8831 8831
=======================================
Hits 8049 8049
Misses 782 782 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This double-define triggers warnings (and warnings-as-errors) and, unfortunately, halts some of my builds and CI (like so). It's certainly not a big problem, but the fix is simple and it would be nice.
Description
When building on Windows with Clang or Clang-cl, the combination of
__clang__and_MSC_VERbeing defined at the same time trips up a multi-definition error in the configuration of catch's internals for warning suppression.This PR fixes that by being specifically for MSVC OR Clang, but not both.
GitHub Issues
None (at least none I could find).