Skip to content

fix(QTM-402): Correction in the display of emoji instead of the balloon position indicator arrow #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcosViniciusPC merged 2 commits into from
Jan 17, 2025
Merged

fix(QTM-402): Correction in the display of emoji instead of the balloon position indicator arrow #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c334d26
fix(Popover.jsx): Correction in the display of emoji instead of the b…
MarcosViniciusPC Jan 17, 2025
c07e23f
test: Updated snapshots
MarcosViniciusPC Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions components/Popover/__snapshots__/Popover.unit.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ exports[`Popover component should match snapshots 1`] = `
color: #ffffff;
font-size: 16px;
position: absolute;
content: '▼';
content: '▼︎';
left: 50%;
text-shadow: 0px 8px 4px rgba(66,66,66,0.2);
bottom: 0;
Expand Down Expand Up @@ -314,7 +314,7 @@ exports[`Popover component should match snapshots 2`] = `
color: #ffffff;
font-size: 16px;
position: absolute;
content: '▼';
content: '▼︎';
left: 50%;
text-shadow: 0px 8px 4px rgba(66,66,66,0.2);
bottom: 0;
Expand Down Expand Up @@ -515,7 +515,7 @@ exports[`Popover component should match snapshots 3`] = `
color: #dcedc8;
font-size: 16px;
position: absolute;
content: '▼';
content: '▼︎';
left: 50%;
text-shadow: 0px 8px 4px rgba(66,66,66,0.2);
bottom: 0;
Expand Down Expand Up @@ -720,7 +720,7 @@ exports[`Popover component should match snapshots 4`] = `
color: #ffefd6;
font-size: 16px;
position: absolute;
content: '▼';
content: '▼︎';
left: 50%;
text-shadow: 0px 8px 4px rgba(66,66,66,0.2);
bottom: 0;
Expand Down Expand Up @@ -929,7 +929,7 @@ exports[`Popover component should match snapshots 5`] = `
color: #fff5f5;
font-size: 16px;
position: absolute;
content: '▼';
content: '▼︎';
left: 50%;
text-shadow: 0px 8px 4px rgba(66,66,66,0.2);
bottom: 0;
Expand Down Expand Up @@ -1139,7 +1139,7 @@ exports[`Popover component should match snapshots 6`] = `
font-size: 16px;
position: absolute;
top: -4px;
content: '▲';
content: '▲︎';
left: 50%;
text-shadow: 0px -3px 4px rgba(66,66,66,0.2);
-webkit-transform: translateX(-50%);
Expand Down Expand Up @@ -1348,7 +1348,7 @@ exports[`Popover component should match snapshots 7`] = `
font-size: 16px;
position: absolute;
bottom: 50%;
content: '▶';
content: '▶︎';
right: -8px;
text-shadow: 4px 1px 4px rgba(66,66,66,0.2);
}
Expand Down Expand Up @@ -1554,7 +1554,7 @@ exports[`Popover component should match snapshots 8`] = `
font-size: 16px;
position: absolute;
bottom: 50%;
content: '◀';
content: '◀︎';
left: -8px;
text-shadow: -4px 1px 4px rgba(66,66,66,0.2);
}
Expand Down Expand Up @@ -1759,7 +1759,7 @@ exports[`Popover component should match snapshots 9`] = `
color: #424242;
font-size: 16px;
position: absolute;
content: '▼';
content: '▼︎';
left: 50%;
text-shadow: 0px 8px 4px rgba(66,66,66,0.2);
bottom: 0;
Expand Down
8 changes: 4 additions & 4 deletions components/Popover/arrowProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,28 @@ const CENTER_POSITION = '50%';

const placementPosition = ({ neutral: { 700: shadowColor } }) => ({
top: `
content: '▼';
content: '\u25BC\uFE0E';
left: ${CENTER_POSITION};
text-shadow: 0px 8px 4px ${hexToRgba(shadowColor, 0.2)};
bottom: 0;
transform: translateX(-${CENTER_POSITION});
`,
bottom: `
top: -4px;
content: '▲';
content: '\u25B2\uFE0E';
left: ${CENTER_POSITION};
text-shadow: 0px -3px 4px ${hexToRgba(shadowColor, 0.2)};
transform: translateX(-${CENTER_POSITION});
`,
right: `
bottom: ${CENTER_POSITION};
content: '◀';
content: '\u25C0\uFE0E';
left: ${SIDE_POSITION_X}px;
text-shadow: -4px 1px 4px ${hexToRgba(shadowColor, 0.2)};
`,
left: `
bottom: ${CENTER_POSITION};
content: '▶';
content: '\u25B6\uFE0E';
right: ${SIDE_POSITION_X}px;
text-shadow: 4px 1px 4px ${hexToRgba(shadowColor, 0.2)};
`,
Expand Down