Skip to content

Refactor orientation rules loop #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
this-is-sofia merged 6 commits into from
Feb 8, 2025
Merged

Refactor orientation rules loop #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b3bed1
add test mpg example loop noncollider rool that fails
this-is-sofia Feb 7, 2025
bce48a4
bug fixing
this-is-sofia Feb 8, 2025
5272604
add tests that show that noncollider rule works but loop is broken
this-is-sofia Feb 8, 2025
b6b2f3d
fix tests that also did the non collider tests
LilithWittmann Feb 8, 2025
28afed7
skeleton and orientations after collider rule are correctly discovere…
this-is-sofia Feb 8, 2025
c757f41
fml
this-is-sofia Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions causy/causal_discovery/constraint/orientation_rules/pc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,13 @@ def process(
# It cannot be a collider because we have already oriented all unshielded triples that contain colliders.
for z in potential_zs:
z = graph.nodes[z]
print(f"x: {x.name}, y: {y.name}, z: {z.name}")
breakflag = False
if graph.only_directed_edge_exists(x, z) and graph.undirected_edge_exists(
z, y
):
for node in graph.nodes:
if graph.only_directed_edge_exists(graph.nodes[node], y):
if graph.only_directed_edge_exists(graph.nodes[node], y) and not graph.edge_exists(graph.nodes[node], z):
breakflag = True
break
if breakflag is True:
Expand All @@ -273,14 +274,19 @@ def process(
action=TestResultAction.REMOVE_EDGE_DIRECTED,
data={"between": {"x": x, "y": y, "z": z}},
)

print(graph.only_directed_edge_exists(y, z))
print(graph.undirected_edge_exists(z, x))
if z.name in graph.edges:
if x.name in graph.edges[z.name]:
print(f"{z.name} -> {x.name}")
if graph.only_directed_edge_exists(y, z) and graph.undirected_edge_exists(
z, x
):
for node in graph.nodes:
if graph.only_directed_edge_exists(graph.nodes[node], x):
breakflag = True
break
print(f"breakflag: {breakflag}")
if breakflag is True:
return TestResult(
u=x,
Expand Down
272 changes: 272 additions & 0 deletions tests/test_orientation_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from causy.causal_discovery.constraint.algorithms.pc import PC_ORIENTATION_RULES
from causy.common_pipeline_steps.exit_conditions import ExitOnNoActions
from causy.common_pipeline_steps.logic import Loop
from causy.edge_types import DirectedEdge, UndirectedEdge
Expand Down Expand Up @@ -436,6 +437,277 @@ def test_non_collider_test(self):
self.assertTrue(model.graph.only_directed_edge_exists(x, y))
self.assertTrue(model.graph.only_directed_edge_exists(y, z))

def test_non_collider_test_auto_mpg_graph_after_collider_rule_noncollider_test(
self,
):
pipeline = [NonColliderTest()]
model = graph_model_factory(
Algorithm(
pipeline_steps=pipeline,
edge_types=[DirectedEdge(), UndirectedEdge()],
name="TestCollider",
)
)()
model.graph = GraphManager()
acceleration = model.graph.add_node("acceleration", [])
horsepower = model.graph.add_node("horsepower", [])
mpg = model.graph.add_node("mpg", [])
cylinders = model.graph.add_node("cylinders", [])
displacement = model.graph.add_node("displacement", [])
weight = model.graph.add_node("weight", [])

model.graph.add_edge(mpg, weight, {})
model.graph.add_edge(displacement, cylinders, {})
model.graph.add_edge(horsepower, displacement, {})

# collider acceleration -> horsepower <- weight
model.graph.add_directed_edge(acceleration, horsepower, {})
model.graph.add_directed_edge(weight, horsepower, {})
# collider mpg -> horsepower <- acceleration
model.graph.add_directed_edge(mpg, horsepower, {})
# collider acceleration -> displacement <- weight
model.graph.add_directed_edge(weight, displacement, {})
model.graph.add_directed_edge(acceleration, displacement, {})

model.execute_pipeline_steps()
# test NonColliderTest
self.assertTrue(
model.graph.edge_of_type_exists(displacement, cylinders, DirectedEdge())
)
self.assertTrue(
model.graph.edge_of_type_exists(horsepower, displacement, DirectedEdge())
)

def test_non_collider_test_auto_mpg_graph_after_collider_rule_whole_loop(self):
pipeline = [
Loop(
pipeline_steps=[
NonColliderTest(display_name="Non-Collider Test"),
FurtherOrientTripleTest(display_name="Further Orient Triple Test"),
OrientQuadrupleTest(display_name="Orient Quadruple Test"),
FurtherOrientQuadrupleTest(
display_name="Further Orient Quadruple Test"
),
],
display_name="Orientation Rules Loop",
exit_condition=ExitOnNoActions(),
),
]
model = graph_model_factory(
Algorithm(
pipeline_steps=pipeline,
edge_types=[DirectedEdge(), UndirectedEdge()],
name="TestLoopAutoMpgGraph",
)
)()
model.graph = GraphManager()
acceleration = model.graph.add_node("acceleration", [])
horsepower = model.graph.add_node("horsepower", [])
mpg = model.graph.add_node("mpg", [])
cylinders = model.graph.add_node("cylinders", [])
displacement = model.graph.add_node("displacement", [])
weight = model.graph.add_node("weight", [])

model.graph.add_edge(mpg, weight, {})
model.graph.add_edge(displacement, cylinders, {})
model.graph.add_edge(horsepower, displacement, {})

# collider acceleration -> horsepower <- weight
model.graph.add_directed_edge(acceleration, horsepower, {})
model.graph.add_directed_edge(weight, horsepower, {})
# collider mpg -> horsepower <- acceleration
model.graph.add_directed_edge(mpg, horsepower, {})
# collider acceleration -> displacement <- weight
model.graph.add_directed_edge(weight, displacement, {})
model.graph.add_directed_edge(acceleration, displacement, {})

model.execute_pipeline_steps()
# test NonColliderTest
self.assertTrue(
model.graph.edge_of_type_exists(displacement, cylinders, DirectedEdge())
)
self.assertTrue(
model.graph.edge_of_type_exists(horsepower, displacement, DirectedEdge())
)

def test_only_non_collider_rule_on_loop_test_model(self):
pipeline = [NonColliderTest()]
model = graph_model_factory(
Algorithm(
pipeline_steps=pipeline,
edge_types=[DirectedEdge(), UndirectedEdge()],
name="TestLoop",
)
)()
model.graph = GraphManager()
x = model.graph.add_node("X", [])
y = model.graph.add_node("Y", [])
z = model.graph.add_node("Z", [])
w = model.graph.add_node("W", [])
model.graph.add_edge(z, w, {})
model.graph.add_directed_edge(x, z, {})
model.graph.add_directed_edge(y, z, {})
model.execute_pipeline_steps()
self.assertTrue(model.graph.edge_of_type_exists(x, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(y, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(z, w, DirectedEdge()))

def test_loop(self):
pipeline = [
Loop(
pipeline_steps=[
NonColliderTest(display_name="Non-Collider Test"),
FurtherOrientTripleTest(display_name="Further Orient Triple Test"),
OrientQuadrupleTest(display_name="Orient Quadruple Test"),
FurtherOrientQuadrupleTest(
display_name="Further Orient Quadruple Test"
),
],
display_name="Orientation Rules Loop",
exit_condition=ExitOnNoActions(),
)
]
model = graph_model_factory(
Algorithm(
pipeline_steps=pipeline,
edge_types=[DirectedEdge(), UndirectedEdge()],
name="TestLoop",
)
)()
model.graph = GraphManager()
x = model.graph.add_node("X", [])
y = model.graph.add_node("Y", [])
z = model.graph.add_node("Z", [])
w = model.graph.add_node("W", [])
model.graph.add_edge(z, w, {})
model.graph.add_directed_edge(x, z, {})
model.graph.add_directed_edge(y, z, {})
model.execute_pipeline_steps()
self.assertTrue(model.graph.edge_of_type_exists(x, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(y, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(z, w, DirectedEdge()))

def test_loop_two_iterations(self):
pipeline = [
Loop(
pipeline_steps=[
NonColliderTest(display_name="Non-Collider Test"),
FurtherOrientTripleTest(display_name="Further Orient Triple Test"),
OrientQuadrupleTest(display_name="Orient Quadruple Test"),
FurtherOrientQuadrupleTest(
display_name="Further Orient Quadruple Test"
),
],
display_name="Orientation Rules Loop",
exit_condition=ExitOnNoActions(),
)
]
model = graph_model_factory(
Algorithm(
pipeline_steps=pipeline,
edge_types=[DirectedEdge(), UndirectedEdge()],
name="TestLoop",
)
)()
model.graph = GraphManager()
x = model.graph.add_node("X", [])
y = model.graph.add_node("Y", [])
z = model.graph.add_node("Z", [])
w = model.graph.add_node("W", [])
v = model.graph.add_node("V", [])
model.graph.add_edge(z, w, {})
model.graph.add_edge(w, v, {})
model.graph.add_directed_edge(x, z, {})
model.graph.add_directed_edge(y, z, {})
model.execute_pipeline_steps()
self.assertTrue(model.graph.edge_of_type_exists(x, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(y, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(z, w, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(w, v, DirectedEdge()))

def test_only_noncollider_rule_on_loop_model_after_one_iteration(self):
pipeline = [
Loop(
pipeline_steps=[
NonColliderTest(display_name="Non-Collider Test"),
],
display_name="NonColliderTest",
exit_condition=ExitOnNoActions(),
)
]
model = graph_model_factory(
Algorithm(
pipeline_steps=pipeline,
edge_types=[DirectedEdge(), UndirectedEdge()],
name="TestLoop",
)
)()
model.graph = GraphManager()
x = model.graph.add_node("X", [])
y = model.graph.add_node("Y", [])
z = model.graph.add_node("Z", [])
w = model.graph.add_node("W", [])
v = model.graph.add_node("V", [])
model.graph.add_edge(w, v, {})
model.graph.add_directed_edge(z, w, {})
model.graph.add_directed_edge(x, z, {})
model.graph.add_directed_edge(y, z, {})
model.execute_pipeline_steps()
self.assertTrue(model.graph.edge_of_type_exists(x, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(y, z, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(z, w, DirectedEdge()))
self.assertTrue(model.graph.edge_of_type_exists(w, v, DirectedEdge()))

def test_non_collider_loop_auto_mpg_graph(self):
pipeline = [
Loop(
pipeline_steps=[
NonColliderTest(display_name="Non-Collider Test"),
FurtherOrientTripleTest(display_name="Further Orient Triple Test"),
OrientQuadrupleTest(display_name="Orient Quadruple Test"),
FurtherOrientQuadrupleTest(
display_name="Further Orient Quadruple Test"
),
],
display_name="Orientation Rules Loop",
exit_condition=ExitOnNoActions(),
)
]
model = graph_model_factory(
Algorithm(
pipeline_steps=pipeline,
edge_types=[DirectedEdge(), UndirectedEdge()],
name="TestCollider",
)
)()
model.graph = GraphManager()

acceleration = model.graph.add_node("acceleration", [])
horsepower = model.graph.add_node("horsepower", [])
mpg = model.graph.add_node("mpg", [])
cylinders = model.graph.add_node("cylinders", [])
displacement = model.graph.add_node("displacement", [])
weight = model.graph.add_node("weight", [])

model.graph.add_edge(mpg, weight, {})
model.graph.add_edge(displacement, cylinders, {})
model.graph.add_edge(horsepower, displacement, {})

model.graph.add_directed_edge(acceleration, horsepower, {})
model.graph.add_directed_edge(mpg, horsepower, {})
model.graph.add_directed_edge(weight, horsepower, {})
model.graph.add_directed_edge(weight, displacement, {})
model.graph.add_directed_edge(acceleration, displacement, {})

model.execute_pipeline_steps()

self.assertTrue(
model.graph.edge_of_type_exists(displacement, cylinders, DirectedEdge())
)
self.assertTrue(
model.graph.edge_of_type_exists(horsepower, displacement, DirectedEdge())
)

def test_further_orient_triple_test(self):
pipeline = [FurtherOrientTripleTest()]
model = graph_model_factory(
Expand Down
Loading
Loading