add logic to blueprint to conditionally install ember-get-helper#115
Open
BrianSipple wants to merge 1 commit intomasterfrom
Open
add logic to blueprint to conditionally install ember-get-helper#115BrianSipple wants to merge 1 commit intomasterfrom
ember-get-helper#115BrianSipple wants to merge 1 commit intomasterfrom
Conversation
BrianSipple
force-pushed
the
conditional-ember-get-helper
branch
from
0bdff22 to
cfb5c07
Compare
Collaborator
Author
|
On second, thought, we'll still need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83.
After getting a better understanding of what this was going for, I think a good solution would be to simply check the installing project's
emberversion inside of our blueprint, and then only addember-get-helperto the project if necessary. As such, I also removed it from our own dependencies.