Improve add/remove-column functionality for basic-table demo component#118
Open
BrianSipple wants to merge 1 commit intomasterfrom
Open
Improve add/remove-column functionality for basic-table demo component#118BrianSipple wants to merge 1 commit intomasterfrom
BrianSipple wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that our
basic-tabledemo was behaving in such a way that it would delete all columns except for the first column when trying to performremoveAColumn, (and the first column itself would be impossible to remove).Maybe I'm wrong, but it seemed like the behavior we were going for was always removing the last dynamic column -- so I refactored the structure a bit to make that work.