Merged
Conversation
Update octave_notes.txt
cbm755
reviewed
Apr 28, 2025
|
|
||
| Comments on existing commits: | ||
| - [octave: temporary workaround for f.funs{j}] not quite sure what the error is here, chaining subsref seems to work when I create toy examples | ||
| - [silence warning by reordering switch]: no longer produces a warning when fieldnames is called on a classdef |
Owner
There was a problem hiding this comment.
do you mean this particular patch is not longer needed?
Collaborator
Author
There was a problem hiding this comment.
Yes, I don't think those two patches are needed anymore, though I might be wrong about the subsref one, I'm not sure what the original problem was or what the workaround was designed to achieve
Owner
There was a problem hiding this comment.
Maybe you can try reverting that commit, check that test octave_tests passes and sending a MR against octave_dev25?
Owner
|
ok, I'm going to merge this and then cherry-pick it into #4, which is the same as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.