feat: sort bindings by key text within each group - #21
Merged
Conversation
Sort bindings alphabetically by binding text (case-sensitive) using insertion sort in the AWK parser. Set LC_ALL=C for consistent byte-order comparison regardless of the user's locale.
There was a problem hiding this comment.
Pull request overview
This PR makes the binding list output deterministic and easier to scan by sorting bindings alphabetically (byte-order, case-sensitive) within each group, and by ensuring the sort order is stable across user locales.
Changes:
- Added an insertion sort routine in
scripts/parse-bindings.awkand applied it per table before emittingBINDlines. - Ran the AWK parser under
LC_ALL=Cin the popup entrypoint to ensure locale-independent ordering. - Updated scrut tests to set
LC_ALL=Cand to match the new sorted output order.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/parse-bindings.scrut | Updates expected output order per group and forces LC_ALL=C for deterministic test results. |
| scripts/popup.sh | Ensures runtime parsing uses LC_ALL=C so sorting is consistent across locales. |
| scripts/parse-bindings.awk | Introduces per-table insertion sort and applies it before printing each group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort bindings alphabetically by binding text (case-sensitive) using
insertion sort in the AWK parser. Set LC_ALL=C for consistent
byte-order comparison regardless of the user's locale.