feature/close by clicking outside - #23
Merged
Merged
Conversation
cboone
commented
Feb 9, 2026
cboone
commented
Owner
- build: add Makefile with test target
- feat: close popup on click outside content area
Detect out-of-bounds mouse coordinates in the viewer and break the main loop, allowing the popup to close when the user clicks outside it.
* main: docs: add Copilot instruction for awk string comparison in sort docs: add Copilot instructions for cross-file link checks docs: fix Scrut URL and remove stale line count chore: add workmux config build: add Makefile with test target docs: update CLAUDE feat: sort bindings by key text within each group feat: make search case-sensitive refactor: combine duplicate ENTER and DOWN handlers in search mode feat: exit search mode on down arrow key # Conflicts: # .claude/CLAUDE.md
There was a problem hiding this comment.
Pull request overview
Adds mouse-driven dismissal behavior to the tmux popup viewer and introduces a make test entrypoint for running Scrut tests, with accompanying documentation updates.
Changes:
- Add mouse column tracking and an out-of-bounds click check to close the popup when clicking outside.
- Add a
Makefilewith atesttarget that runs the existing Scrut test suite. - Update internal docs to reference
make testand document the outside-click behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/viewer.sh |
Extends mouse click tokens to include column and breaks the main loop on out-of-bounds clicks. |
Makefile |
Adds a test target to run scrut test -w . tests. |
.claude/CLAUDE.md |
Updates testing instructions to use make test (via the new Makefile). |
docs/plans/done/2026-02-08-close-popup-on-outside-click.md |
Documents the outside-click feature and intended implementation details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.