Open
Conversation
added 8 commits
March 26, 2017 16:31
Collaborator
|
Is this outdated & can be closed? @rhenwood39 |
Collaborator
Author
|
We should probably merge this in eventually because it makes ESClient and URModel more testable. I'm not sure if anyone has tried doing it yet...? If no one has tried yet, it might honestly be easier to close this and just put in new pull request because it looks like there will be a lot of merge conflicts. And all the changes in this branch were pretty simple, so it would be easy to just redo everything. But for now I guess we should just leave it open. Since this is mostly style stuff, we can worry about it after we get everything working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stopped EsClient from being a singleton, and refactored a few things using dependency injection (e.g. EsClient, URModel, etc.) to improve testability.