Merged
Conversation
- pre-commit basic config: remove trailing white spaces, ... - typos: try to fix spell check errors
Owner
|
Thanks! If I run on Debian (bookworm) I get this: |
Contributor
Author
|
I've just a ubuntu 24.04 at hand, and on my side when I run the command, everything is fine pkestene@home [fix-minors-typos → origin] ~/install/p4est/github/p4est % pre-commit run --all-files
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check for added large files..............................................Passed
typos....................................................................PassedI'm using pre-commit from the package manager, i.e. version 3.6.2 (no special python environment). Also Can you just look at log to see what's wrong on your machine ? |
Owner
|
Merging, since this is well tested on your side after all. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre-commit hooks config and fix reported typos
This is a companion PR to the one made in libsc : cburstedde/libsc#229
This PR adds configuration files for using
pre-commit, e.g.It can be run in command line terminal with
pre-commit run --all-files(pre-commitis available either as a system package in Debian/Ubuntu or from a python package manager) . It could in principle be placed in a CI script, but it sometimes detects false positives (e.g. abbreviated variable names), so it is better to have a human eyes to cross-check.False positives can be listed in
_typos.tomlso that they are ignored by the spell checker.