Conversation
Owner
Author
|
@ShreyasMahen and Anudeep - can you review this code? |
Collaborator
|
After reviewing this code, yes I think this change looks fine.... The comments are clear, and the logic works as expected.... |
Collaborator
|
This does a great job illustrating the difference between command substitution and arithmetic evaluation in Bash. |
Owner
Author
|
Thanks @x-anudeep and @ShreyasMahen - I think you still need to actually approve the changes so this PR can be merged. |
x-anudeep
approved these changes
Oct 16, 2025
Collaborator
x-anudeep
left a comment
x-anudeep
left a comment
There was a problem hiding this comment.
Yes I think these changes are good to go..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think everyone? Great work, right?!!