Skip to content

Finish 2026 south tri ingest#990

Merged
wagnerlmichael merged 4 commits intomasterfrom
finish-2026-south-tri-manual-review-sale-ingest-from-team
Feb 26, 2026
Merged

Finish 2026 south tri ingest#990
wagnerlmichael merged 4 commits intomasterfrom
finish-2026-south-tri-manual-review-sale-ingest-from-team

Conversation

@wagnerlmichael
Copy link
Member

@wagnerlmichael wagnerlmichael commented Feb 25, 2026

Finish up ingesting the final round of south tri 2026 sales from valuations' 2026 capacity.

Total number of reviewed sales increased from 4103 to 4737.

The main complication with this ingest was that some data had hidden rows with different reviewers in the WHOM field that this script was picking up due the way we detect which rows to keep (NA checking), which took me a while to figure out. I basically ignore these fields, on the assumption that since they were hidden they weren't meant to be the ones we were looking at.

Also fixed some other duplication that arose upon replacing the updated files.

@wagnerlmichael wagnerlmichael changed the title draft Finish 2026 south tri ingest Feb 25, 2026
@wagnerlmichael wagnerlmichael marked this pull request as ready for review February 26, 2026 15:28
@wagnerlmichael wagnerlmichael requested a review from a team as a code owner February 26, 2026 15:28
@wagnerlmichael
Copy link
Member Author

Note: I have not ran this script all the way through the upload. It will likely change some prod sales val classifications, and I wanted to double-check to make sure there isn't any sort of lingering model clean up work that would cause us to want to wait.

Copy link
Member

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! Feel free to run the script and output to the prod database, I don't expect it should interfere with model finalization for this year.

@wagnerlmichael wagnerlmichael merged commit 3ab5597 into master Feb 26, 2026
6 checks passed
@wagnerlmichael wagnerlmichael deleted the finish-2026-south-tri-manual-review-sale-ingest-from-team branch February 26, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants