Merged
Conversation
Member
Author
|
Note: I have not ran this script all the way through the upload. It will likely change some prod sales val classifications, and I wanted to double-check to make sure there isn't any sort of lingering model clean up work that would cause us to want to wait. |
jeancochrane
approved these changes
Feb 26, 2026
Member
jeancochrane
left a comment
There was a problem hiding this comment.
Thanks so much for this! Feel free to run the script and output to the prod database, I don't expect it should interfere with model finalization for this year.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish up ingesting the final round of south tri 2026 sales from valuations' 2026 capacity.
Total number of reviewed sales increased from 4103 to 4737.
The main complication with this ingest was that some data had hidden rows with different reviewers in the
WHOMfield that this script was picking up due the way we detect which rows to keep (NA checking), which took me a while to figure out. I basically ignore these fields, on the assumption that since they were hidden they weren't meant to be the ones we were looking at.Also fixed some other duplication that arose upon replacing the updated files.