Open
Conversation
eb-oss
approved these changes
Apr 16, 2018
Collaborator
Author
|
This is not yet working as planned. The following setup fails:
|
… order to prevent cross-stack registrations / deregistrations
… a bug where we were deregistering instances in other vpcs, that our vpc-specific metadata did not describe
Bugfix/devops 556
change log level to debug for skipping-due-to-different-stack message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports the use-case where we have a rancher env spanning multiple aws accounts - we need the ability to target an aws-elb service to a specific set of services. Adding a custom label to the service, and allowing a customized label that aws-elb looks for, provides that functionality.