Skip to content

DEVOPS-542 allow customized endpoint label#3

Open
chessracer wants to merge 8 commits intomasterfrom
feature/DEVOPS-542
Open

DEVOPS-542 allow customized endpoint label#3
chessracer wants to merge 8 commits intomasterfrom
feature/DEVOPS-542

Conversation

@chessracer
Copy link
Copy Markdown
Collaborator

This supports the use-case where we have a rancher env spanning multiple aws accounts - we need the ability to target an aws-elb service to a specific set of services. Adding a custom label to the service, and allowing a customized label that aws-elb looks for, provides that functionality.

@chessracer chessracer requested a review from eb-oss April 16, 2018 20:06
@chessracer chessracer self-assigned this Apr 25, 2018
@chessracer
Copy link
Copy Markdown
Collaborator Author

This is not yet working as planned. The following setup fails:

  • hosts in rancher env are all in same aws account
  • single rancher env, with multiple stacks
  • each stack has an aws-elb configured with a custom SERVICE_LABEL_ENDPOINT
    The aws-elb's do not correctly ignore services with different SERVICE_LABEL_ENDPOINT 's, and wind up deregistering eachother's instances.
    The setup does work in the original use-case, where the rancher env spans multiple aws accounts - in that scenario, the aws-elb's cannot find the other env's elb's to "deregister" them.
    This behavior should be corrected so that it completely ignores services with different SERVICE_LABEL_ENDPOINT 's .

chessracer and others added 6 commits April 25, 2018 09:28
… order to prevent cross-stack registrations / deregistrations
… a bug where we were deregistering instances in other vpcs, that our vpc-specific metadata did not describe
change log level to debug for skipping-due-to-different-stack message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants