deps: drop unused RUST_VERSION, NODE_VERSION, ELM_VERSION pins#56
Merged
Conversation
These three values were declared in versions.env but never consumed by any build script, workflow or Dockerfile in this repo: - RUST_VERSION: there is no Rust code here (no Cargo.toml, no rust-toolchain.toml). - NODE_VERSION: there is no Node code here (no package.json). - ELM_VERSION: where Elm is used downstream, its version is encoded in elm.json — a duplicate env pin would only drift. Also tightens the file header to make the scope explicit (Haskell + MUMPS + OpenBLAS).
ccomb
force-pushed
the
drop-cross-bleed-vars
branch
from
e05a3de to
0b253d6
Compare
ccomb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versions.envdeclared three pins that no build script, workflow or Dockerfile in this repo actually consumes:RUST_VERSION— there is no Rust code here (noCargo.toml, norust-toolchain.toml).NODE_VERSION— there is no Node code here (nopackage.json).ELM_VERSION— where Elm is used downstream, its canonical version is encoded inelm.json; a duplicate env pin would only drift.Removing them stops the file from advertising contracts it doesn't keep. Also tightens the file header to make the scope explicit (Haskell + MUMPS + OpenBLAS).
Test plan
_build-matrix.ymlstays green — none of the removed variables are referenced by any build artifact in this repo