Skip to content

стилизация компонента button#11

Open
khaliulin wants to merge 6 commits intofeature/styles-debugfrom
feature/button-example
Open

стилизация компонента button#11
khaliulin wants to merge 6 commits intofeature/styles-debugfrom
feature/button-example

Conversation

@khaliulin
Copy link

No description provided.

@khaliulin khaliulin requested a review from AxyIX March 23, 2026 10:38
[icon]="icon"
[iconPos]="primeIconPos"
[severity]="primeSeverity"
></p-button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нет тэга
он нужен что бы передавать контент извне внутрь кнопки
у прайма он есть, думаю нам тоже нужно
но это надо подумать, будут ли у нас кейсы, что мы будем верстку в кнопку передавать

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX возможно, ты имел ввиду Badge – https://primeng.org/button#badge? да, его планируем передавать в кнопку; фикс здесь 630c163

@Input() iconOnly = false;
@Input() icon = '';
@Input() disabled = false;
@Input() loading = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут не все пропсы
из памяти - outlined, text

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX outlined нам не надо; добавил пропсы fluid, ariaLabel, autofocus, tabindex в коммите c70bdb2

@@ -0,0 +1 @@
[ 388ms] [ERROR] Failed to load resource: the server responded with a status of 404 () @ https://raw.githubusercontent.com/cdek-it/vue-ui-kit/storybook-update/src/assets/style/vars/_colors.scss:0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

всякие логи и генерируемые файлы мы не коммитим

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX сделал фикс: 1e7db4f

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

этот файл тоже не коммитим

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX фикс 18e19a7

.p-button-xlg.p-button-icon-only {
width: var(--p-button-extend-ext-xlg-icon-only-width);
height: var(--p-button-extend-ext-xlg-icon-only-width);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

как-то много переопределений стилей
точно всё это нужно?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AxyIX да, компонент Button самый большой по кол-ву переопределений стилей.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants