inputtext: стилизация, сторисы, токены#171
Open
khaliulin wants to merge 55 commits intostorybook-updatefrom
Open
inputtext: стилизация, сторисы, токены#171khaliulin wants to merge 55 commits intostorybook-updatefrom
khaliulin wants to merge 55 commits intostorybook-updatefrom
Conversation
khaliulin
force-pushed
the
form/InputText
branch
from
bd22ba2 to
4ac21fd
Compare
Skosov
reviewed
Mar 26, 2026
Skosov
reviewed
Mar 26, 2026
Skosov
reviewed
Mar 31, 2026
Skosov
reviewed
Mar 31, 2026
Member
|
Решить конфликты |
Skosov
reviewed
Apr 6, 2026
Member
There was a problem hiding this comment.
почему этот файл вообще в этом ПР редактируется?
Collaborator
Author
Skosov
reviewed
Apr 6, 2026
Skosov
reviewed
Apr 6, 2026
| argTypes: { | ||
| size: { | ||
| control: 'select', | ||
| options: ['small', 'medium', 'large', 'xlarge'], |
Member
There was a problem hiding this comment.
прайм не умеет в xlarge, нужен какой-то коммент, что нужно использовать зарезервированный класс
Collaborator
Author
added 5 commits
April 6, 2026 12:56
…-класс p-inputtext-xlg
Collaborator
Author
Skosov
reviewed
Apr 24, 2026
Member
There was a problem hiding this comment.
навзание файла видимо прошлое вернулось
Member
There was a problem hiding this comment.
а, ну в целом файл просто остался почему-то
Collaborator
Author
Collaborator
Author
Skosov
reviewed
Apr 24, 2026
| import { IconX } from '@tabler/icons-vue'; | ||
|
|
||
| const props = withDefaults( | ||
| defineProps<{ |
Member
There was a problem hiding this comment.
почему исчезло наследование от базового текст инпута?
Collaborator
Author
Skosov
reviewed
Apr 24, 2026
Comment on lines
+10
to
+14
| invalid?: boolean; | ||
| disabled?: boolean; | ||
| readonly?: boolean; | ||
| placeholder?: string; | ||
| fluid?: boolean; |
Member
There was a problem hiding this comment.
нет смысла описывать, если наследоваться
Collaborator
Author
Skosov
reviewed
Apr 24, 2026
added 3 commits
April 24, 2026 14:56
Skosov
reviewed
Apr 24, 2026
| import { IconX } from '@tabler/icons-vue'; | ||
| import { computed } from 'vue'; | ||
|
|
||
| interface PBlockInputTextProps extends /* @vue-ignore */ InputTextProps { |
Member
There was a problem hiding this comment.
не вижу прокидывания пропса has-floatlabel
Collaborator
Author
added 4 commits
April 24, 2026 15:48
Skosov
reviewed
Apr 24, 2026
Skosov
reviewed
Apr 24, 2026
Collaborator
Author
Skosov
reviewed
Apr 24, 2026
| } | ||
|
|
||
| &__required { | ||
| color: var(--p-red-500); |
Member
There was a problem hiding this comment.
@khaliulin коммент для меня. Проверить как еще можно читать токены прайма на стороне оберток
Skosov
reviewed
Apr 24, 2026
|
|
||
| &__required { | ||
| color: var(--p-red-500); | ||
| margin-left: 2px; |
Collaborator
Author
Skosov
reviewed
Apr 24, 2026
| </script> | ||
|
|
||
| <template> | ||
| <FloatLabel v-if="hasFloatlabel" variant="in"> |
Member
There was a problem hiding this comment.
в ds не планируется других вариантов использования флоатов?
Member
There was a problem hiding this comment.
Ок, но я бы в сториз тогда описал, что возможно использование FloatLabel и PBlockInputText напрямую
Collaborator
Author
Skosov
reviewed
Apr 24, 2026
Comment on lines
+78
to
+100
| <IconField | ||
| v-else | ||
| class="p-block-inputtext" | ||
| :class="{ 'p-block-inputtext--fluid': fluid }" | ||
| > | ||
| <InputText | ||
| v-bind="attrs" | ||
| :modelValue="modelValue" | ||
| :fluid="fluid" | ||
| :size="size === 'xlarge' ? undefined : size" | ||
| :class="{ 'p-inputtext-xlg': size === 'xlarge' }" | ||
| @update:modelValue="onUpdateModelValue($event as string)" | ||
| /> | ||
| <InputIcon | ||
| v-show="showClear && modelValue" | ||
| class="p-block-inputtext__icon" | ||
| @click.stop="onClear" | ||
| > | ||
| <slot name="clear-icon"> | ||
| <IconX :size="14" /> | ||
| </slot> | ||
| </InputIcon> | ||
| </IconField> |
Member
There was a problem hiding this comment.
Дублирование кода, вынести в подкомпонент, переиспользовать в двух случаях
Collaborator
Author
Skosov
reviewed
Apr 27, 2026
| @click.stop="onClear" | ||
| > | ||
| <slot name="clear-icon"> | ||
| <IconX :size="14" /> |
Collaborator
Author
added 4 commits
April 27, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.