Skip to content

Non-results fixes - #79

Merged
gerrycampion merged 16 commits into
mainfrom
CORE-000039
Jul 16, 2026
Merged

Non-results fixes#79
gerrycampion merged 16 commits into
mainfrom
CORE-000039

Conversation

@gerrycampion

@gerrycampion gerrycampion commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator
Rule Type Number Fixed Reason
CORE-000039 negative 1 Move this test to positive 2 - It tests case when PRESP doesn't exist. Rename neg 2 to neg 1. Change 3.3 to 3.4 in env
CORE-000039 negative 2 Change 3.3 to 3.4 in env. rename this to neg 1
CORE-000047 negative 01 Looks like ACTARM is not in output variables but it is relevant to the rule and it should be.
CORE-000092 negative 01 Int -> Float and EC dataset has var labels instead of names
CORE-000093 negative 01 Int -> Float and EC dataset was missing var names
CORE-000093 positive 01 Int -> Float and EC dataset was missing var names
CORE-000097 negative 01 Rule missing key output variables
CORE-000118 negative 01 Rule missing key output variables and should be Record level sensitivity not Dataset level
CORE-000132 negative 01 Change sendig to sdtmig in env
CORE-000141 negative 02 Rule missing key output variables

@gerrycampion
gerrycampion requested a review from SFJohnson24 July 9, 2026 16:20
@gerrycampion
gerrycampion marked this pull request as ready for review July 9, 2026 16:20
@gerrycampion
gerrycampion requested a review from RamilCDISC July 9, 2026 16:20
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

✅ YAML Format Check Passed

All changed rule.yml files are correctly sorted and formatted.

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

Schema Validation Results

Click to expand

Schema Validation Report

Schema: https://raw.githubusercontent.com/cdisc-org/cdisc-rules-engine/refs/heads/main/resources/schema/rule-merged/CORE-base.json

Files checked: 4 | Failed: 0

Published/CORE-000047/rule.yml

Published/CORE-000097/rule.yml

Published/CORE-000118/rule.yml

Published/CORE-000141/rule.yml

View workflow run

@gerrycampion
gerrycampion marked this pull request as draft July 10, 2026 14:51
@gerrycampion gerrycampion changed the title Fix env and tests for CORE-000039 Non-results fixes Jul 10, 2026
@gerrycampion
gerrycampion marked this pull request as ready for review July 16, 2026 13:55
@gerrycampion
gerrycampion merged commit 05fdc66 into main Jul 16, 2026
5 checks passed
@gerrycampion
gerrycampion deleted the CORE-000039 branch July 16, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant