-
Notifications
You must be signed in to change notification settings - Fork 42
pandas #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
pandas #1789
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
25463a3
pandas
SFJohnson24 9226b86
handle 3.0 none type inferring
SFJohnson24 82b6dca
as object
SFJohnson24 9b0cd8d
try agg
SFJohnson24 550383c
none
SFJohnson24 077e79f
agg
SFJohnson24 81037e5
distinct
SFJohnson24 e35947d
remove as_index
SFJohnson24 9516aad
dask
SFJohnson24 233b0d1
dask
SFJohnson24 f196ff7
dask2
SFJohnson24 d823dfc
remove reset_index
SFJohnson24 d5f985a
name return
SFJohnson24 c8bb538
replace NaN
SFJohnson24 4736ea2
refactor
SFJohnson24 2310ffe
revert
SFJohnson24 a28c7cd
usdm
SFJohnson24 9bc282b
dropna
SFJohnson24 13a1103
serialize
SFJohnson24 58b690e
remove comment
SFJohnson24 66c7892
NaN
SFJohnson24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the grouped path used .apply(list) which would preserve the missing values but _apply_dropna_list drops them. If this is intentional then the ungrouped non reference path still uses
data = result[self.params.target].unique()and thenresult = list(data)which preserves the missing values in the list. The distinct operation will have two different behaviors then. Please let me know if I misunderstanding something here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made them have parity