Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cdisc_rules_engine/services/reporting/base_report_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,16 @@ def process_values(
processed_values.append(value)
return processed_values

@abstractmethod
def get_csv_rows(self) -> tuple[list[str], list[list[str]]]:
"""
Return (header, rows) for the CSV output format.
Return (header, sorted_rows) for the CSV output format.
Each row is a list of string values matching the header columns.
Sorting is applied lexicographically by full column order.
"""
header, rows = self._get_csv_rows()
return header, sorted(rows, key=lambda row: tuple(row))

@abstractmethod
def _get_csv_rows(self) -> tuple[list[str], list[list[str]]]:
"""Return (header, rows) before base-class sorting is applied."""
pass
2 changes: 1 addition & 1 deletion cdisc_rules_engine/services/reporting/sdtm_report_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ def _generate_error_details(
)
return errors

def get_csv_rows(self) -> tuple[list[str], list[list[str]]]:
def _get_csv_rows(self) -> tuple[list[str], list[list[str]]]:
header = ["Dataset", "Record", "Variable", "Value"]
rows = []
for issue in self.data_sheets.get("Issue Details", []):
Expand Down
2 changes: 1 addition & 1 deletion cdisc_rules_engine/services/reporting/usdm_report_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def _generate_error_details(
)
return errors

def get_csv_rows(self) -> tuple[list[str], list[list[str]]]:
def _get_csv_rows(self) -> tuple[list[str], list[list[str]]]:
header = ["path", "attribute", "value"]
rows = []
for issue in self.data_sheets.get("Issue Details", []):
Expand Down
Loading