Show target var for not_exists - #1800
Merged
Merged
Conversation
RamilCDISC
approved these changes
Jul 7, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
The PR removes a temporary fix made previously for missing columns in output variables when using not_exists operator as a better solution of putting 'Not in dataset' is already implemented in the engine. The removal of this fix is validated by running a validation against a rule mentioned in the description. Passing of all unit and regression tests supports the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to:
#168
#714
But these are fixed in a better way now, by providing a value of "Not in dataset".
This should fix the issues found in Rule CORE-000029
Needs this test suite PR: https://github.com/cdisc-org/CORE_Test_Suite/pull/101
Action run here: https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/28894280239