484 - #1820
Merged
Merged
Conversation
pendingintent
approved these changes
Aug 11, 2026
pendingintent
left a comment
Collaborator
There was a problem hiding this comment.
When validating against CORE conformance rules for a specific implementation, a rule author should double-check if the rule flags null USUBJID in RELREC as an error by default — some validation engines default to flagging it unless explicitly configured to allow the trial-design-relationship case.
The engine should allow null USUBJID so any rule should be authored considering which domains are being validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small PR for CORE-000484; it is dropping blank USUBJID but blank USUBJID in RELREC are allowed from my understanding.
for the negative/01 open rules test data it drops all the data where usubjid is blank and only reports the last 4 rows. It should report all the rows for the test data as the RELID per USUBJID are unique