Fix value-level greater_than comparator (used < instead of >) - #1822
Open
Rdag15 wants to merge 1 commit into
Open
Fix value-level greater_than comparator (used < instead of >)#1822Rdag15 wants to merge 1 commit into
Rdag15 wants to merge 1 commit into
Conversation
ValueLevelMetadata.greater_than() returned `value < check` -- a copy of less_than() -- so Define-XML value-level where-clauses with Comparator=GT selected the inverse set of rows. greater_than_or_equal_to already uses >=. Add a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueLevelMetadata.greater_than()returnsvalue < check_value— an exact copy ofless_than()— so Define-XML value-level where-clauses withComparator="GT"select the inverse set of rows.greater_than_or_equal_to()already uses>=, so the intended direction is clear.Repro on
main:Fix: change
<to>ingreater_than(). Added a test covering values above, at, and below the check value. One-line change plus test; no other comparator is affected.