Step 1 - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the DDE “Step 1” experience in the renderer UI (layout, navigation behavior, and execution view) and adjusts the main-process Python execution logic to better support running DDE scripts.
Changes:
- Refactors Step 1 (and Step 2/3 pickers) to use inline icon-based file/folder pick actions and introduces an execution-focused Step 1 flow with continue/cancel controls.
- Adds a curated SDTM CT date option list and switches SDTM CT input to a select.
- Updates Python command/env handling in
DdeManagerand adds a unit test around venv interpreter selection.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/utils/sdtmCtOptions.ts | Adds a predefined list of SDTM CT date options for UI selection. |
| src/renderer/redux/initialState.ts | Changes default UI state to start with the app bar expanded. |
| src/renderer/components/Toolpad.tsx | Makes navigation drawer always use expanded width and always render headers. |
| src/renderer/components/DdeStep3/index.tsx | Replaces “Choose …” buttons with end-adornment icon pickers for template/output. |
| src/renderer/components/DdeStep2/index.tsx | Replaces “Choose …” button with an end-adornment icon picker for apply-patch input. |
| src/renderer/components/DdeStep1/index.tsx | Major Step 1 UI restructure (grouped sections, SDTM CT select, execution view, cancel/continue). |
| src/renderer/components/DdeExecution/index.tsx | Adds hideActions/fullHeight props and adjusts layout styling for embedded execution view. |
| src/main/managers/ddeManager.ts | Adds venv discovery + PATH/VIRTUAL_ENV injection and applies it to spawn/execFile. |
| src/main/managers/tests/ddeManager.test.ts | Adds a test asserting venv interpreter usage (needs stabilization). |
Suppressed comments (1)
src/main/managers/ddeManager.ts:57
getPythonEnvrepeats the same hard-coded workspace path to.venv, which makes PATH/VIRTUAL_ENV injection non-portable. Use the same dynamic base path asgetPythonCommand.
const workspaceVenvPath = path.join(
'/home/nogi/nogi/data-definition-engine-ui',
'.venv',
);
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.