Merged
Conversation
Member
|
Thinking maybe this wasn't caught in the original PR but when I change classification I'm not seeing the changed to value "cmj8qf3du0001nb0dejo7nx98","tim.arney@cds-snc.ca","""Data classification changed""","2025-12-16T15:34:28.633Z", |
timarney
reviewed
Dec 16, 2025
Member
timarney
left a comment
There was a problem hiding this comment.
Will wait for QA but outside of my comment on classification this seems to be working well.
22c132c to
3e0f4f2
Compare
3e0f4f2 to
12b04ec
Compare
Member
QA testingLanguage
Form
Settings
API
Team members
Responses
Issues
|
Contributor
🧪 Review environmenthttps://jnbcxxad2xkjjxc5h4er32b43m0fbano.lambda-url.ca-central-1.on.aws/ |
Contributor
Author
|
@anikbrazeau can you retest when you have time? |
bryan-robitaille
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Fixes #6547
Checks what elements of a template are changed before throwing log events that the element was indeed changed.
Remaining Issues:
Download form (says Form JSON updated, don't include)
API key generation/deletion (does not include actual details, only placeholders)
Manage access (missing strings to make it user-readable, sometimes missing attributes {{userEmail}}
To be fixed in a later itteration:
#6627