Skip to content

fix: Removes duplicate log events.#6575

Merged
ShadeWyrm merged 21 commits intomainfrom
fix/remove-duplicate-events
Apr 22, 2026
Merged

fix: Removes duplicate log events.#6575
ShadeWyrm merged 21 commits intomainfrom
fix/remove-duplicate-events

Conversation

@ShadeWyrm
Copy link
Copy Markdown
Contributor

@ShadeWyrm ShadeWyrm commented Dec 15, 2025

Fixes #6547

Checks what elements of a template are changed before throwing log events that the element was indeed changed.

Remaining Issues:
Download form (says Form JSON updated, don't include)
API key generation/deletion (does not include actual details, only placeholders)
Manage access (missing strings to make it user-readable, sometimes missing attributes {{userEmail}}

To be fixed in a later itteration:
#6627

@timarney timarney changed the title * Removes duplicate log events. chore: Removes duplicate log events. Dec 16, 2025
@timarney timarney changed the title chore: Removes duplicate log events. fix: Removes duplicate log events. Dec 16, 2025
@timarney
Copy link
Copy Markdown
Member

Thinking maybe this wasn't caught in the original PR but when I change classification I'm not seeing the changed to value

"cmj8qf3du0001nb0dejo7nx98","tim.arney@cds-snc.ca","""Data classification changed""","2025-12-16T15:34:28.633Z",
"cmj8qf3du0001nb0dejo7nx98","tim.arney@cds-snc.ca","""Data classification changed""","2025-12-16T15:33:51.194Z",
"cmj8qf3du0001nb0dejo7nx98","tim.arney@cds-snc.ca","""Data classification changed""","2025-12-16T15:32:54.874Z",

Copy link
Copy Markdown
Member

@timarney timarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for QA but outside of my comment on classification this seems to be working well.

@ShadeWyrm ShadeWyrm force-pushed the fix/remove-duplicate-events branch from 22c132c to 3e0f4f2 Compare December 29, 2025 17:24
@ShadeWyrm ShadeWyrm force-pushed the fix/remove-duplicate-events branch from 3e0f4f2 to 12b04ec Compare December 29, 2025 17:24
@anikbrazeau
Copy link
Copy Markdown
Member

anikbrazeau commented Dec 29, 2025

QA testing

Language

  • English
  • French

Form

  • Create form
  • Update form name
  • Update form content
  • Duplicate form
  • Archive form
  • Restore form
  • Download form
  • Publish form

Settings

  • Change classification
  • Set form purpose
  • Turn on/off saving progress
  • Open/close form
  • Schedule closing date
  • Turn on/off notifications

API

  • Generate API key
  • Re-generate API key
  • Delete API key
  • Increase throttling

Team members

  • Grant access
  • Revoke access
  • Invite user
  • Accept invitation
  • Decline invitation
  • Cancel invitation

Responses

  • Receive new response
  • Download response
  • Confirm response
  • Delete response
  • Report a problem with response

Issues

  • Update form name (does not include what it changed to)
Screenshot 2025-12-29 at 3 03 47 PM
  • Archive form and Restore form (does not have corresponding string, should not have delete, use restore instead of unarchive to match interface language)
Screenshot 2025-12-29 at 3 04 43 PM
  • Download form (says Form JSON updated, don't include)
Screenshot 2025-12-29 at 3 09 14 PM
  • Publish form (shows draft responses deleted which is perhaps unexpected)
Screenshot 2025-12-29 at 3 27 57 PM
  • Form purpose (should be Intended use and have administrative and non-administrative spelled out to match interface language)
Screenshot 2025-12-29 at 3 08 39 PM
  • Saving progress (true/false should be ON/OFF to match interface language)
Screenshot 2025-12-29 at 3 08 28 PM
  • Notification setting (does not have corresponding string)
Screenshot 2025-12-29 at 3 08 54 PM
  • Open/close form (should be more specific, not just about scheduling if not scheduled)
Screenshot 2025-12-29 at 3 09 05 PM
  • API key generation/deletion (does not include actual details, only placeholders)
Screenshot 2025-12-29 at 3 02 21 PM Screenshot 2025-12-29 at 3 02 33 PM
  • Manage access (missing strings to make it user-readable, sometimes missing attributes {{userEmail}}
Screenshot 2025-12-29 at 3 42 35 PM Screenshot 2025-12-29 at 3 42 22 PM Screenshot 2025-12-29 at 3 42 12 PM

@github-actions
Copy link
Copy Markdown
Contributor

@ShadeWyrm
Copy link
Copy Markdown
Contributor Author

@anikbrazeau can you retest when you have time?

@cds-snc cds-snc deleted a comment from github-actions Bot Apr 16, 2026
@ShadeWyrm ShadeWyrm merged commit 42ff345 into main Apr 22, 2026
15 checks passed
@ShadeWyrm ShadeWyrm deleted the fix/remove-duplicate-events branch April 22, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Events Logged

4 participants