Transform.apply_to_list for inhomogeneous lists#22
Open
switzel wants to merge 2 commits intocduck:masterfrom
Open
Transform.apply_to_list for inhomogeneous lists#22switzel wants to merge 2 commits intocduck:masterfrom
switzel wants to merge 2 commits intocduck:masterfrom
Conversation
Owner
|
Good catch. I will review and merge as soon as I have some free time. On a quick glance it looks like you might have mixed some code from the other PR. |
VascoSch92
reviewed
Feb 22, 2024
| rpt = rot.apply_to_point(pt) | ||
| d = (rpt.x**2 + rpt.y**2 - rpt.x)/(rpt.x - 1) | ||
| return cls.from_closest_point_e_polar(d,theta,cw = cw) | ||
| @classmethod |
Contributor
There was a problem hiding this comment.
leave a space between two methods
| @@ -39,6 +40,13 @@ def from_closest_point(pt, surround_origin=False, cw=True): | |||
| return Horocycle( | |||
| shape, closest_point=pt, surround_origin=surround_origin) | |||
| @classmethod | |||
Contributor
There was a problem hiding this comment.
leave a space between two methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of Transform.apply_to_list assumes its argument to consist entirely of ideal or non-ideal points. Therefore it cannot be applied to the fundamental domain of SL_2(Z), for instance. This change checks the type of each point in the argument individually.