feat: switch hash verification from SHA-256 to xxHash3-64 - #12
Merged
Conversation
Matches Quartermaster PR #372 which changed server-side hashing. Adds System.IO.Hashing NuGet package (zero transitive deps). Catalog now sends 16-char xxHash3-64 hex; VerifyHashes updated to match. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Hash algorithm reference: SHA-256 → xxHash3 - Installation: mention System.IO.Hashing.dll alongside Convoy.dll Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SyncEngine.VerifyHashesto match Quartermaster server change (PR #372)System.IO.HashingNuGet package (v9.0.13, targets net462, zero transitive dependencies)System.IO.Hashing.dllalongsideConvoy.dllVerification
Cross-implementation hash agreement confirmed — C#
XxHash3.GetCurrentHashAsUInt64().ToString("x16")and Rustformat!("{:016x}", xxh3_64(data))produce identical output for all test vectors:"hello world"d447b1ea40e6988bd447b1ea40e6988b""(empty)2d06800538d394c22d06800538d394c2Test plan
System.IO.Hashing.dllpresent in bothbin/Debug/andBuild/BepInEx/plugins/Convoy/Implemented with the help of Claude Code