Conversation
run_pipeline() now detects the academic year (max inschrijvingsjaar) and institution BRIN (most frequent instellingscode) from the raw data when not explicitly provided. create_synthetic is no longer a parameter -- it's automatically enabled only for the demo BRIN "21XX".
Pipeline tab no longer asks for year, BRIN, or synthetic toggle. These are auto-detected from the uploaded EV data and shown to the user before running. Relies on the updated run_pipeline() defaults.
Adds R/run_app.R with exported run_app() function using cli::cli_abort for error messages. Adds shiny, bslib, DT, ggplot2 to Suggests and cli to Imports in DESCRIPTION. Exports run_app in NAMESPACE.
Source dates arrive as numeric integers (e.g. 20080901) but were parsed with %d/%m/%Y format, causing silent conversion to garbage dates like 56949-08-22. Adds parse_date_flexible() that detects numeric input and parses as %Y%m%d. Also adds INS_Datum_tekening_diploma to the conversion block.
Single source of truth for detecting BRIN and year from enrollment data. Used by both run_pipeline() and the Shiny app. Removes duplicated detection logic from pipeline.R and app.R.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect_metadata()utilityrun_app()launcher, fixes YYYYMMDD date parsing, removes manual create_synthetic parameterCloses #5
Test plan
prep1cho::run_app()and upload a raw EV file