Cedar Generalized Templates by alanwang67 · Pull Request #1669 · cedar-policy/cedar

alanwang67 · 2025-06-23T20:49:36Z

Description of changes

Changes for Cedar Generalized Templates . Currently this this works for when a Schema is provided. The API end point that is exposed to end users are a function that allows for the creation of generalized slots and generalized_link which allows users to also provide values besides EntityUIDs.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
[] A bug fix or other functionality change requiring a patch to cedar-policy.
[] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
[] Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

[] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
[] Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
[] I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

[] Does not require updates because my change does not impact the Cedar language specification.
Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-docs. PRs should be targeted at a staging-X.Y branch, not main.)
I'm not sure how my change impacts the documentation. (Post your PR anyways, and we'll discuss in the comments.)

Signed-off-by: Alan Wang <alanwang599@gmail.com>

… slots in protobuf format Signed-off-by: Alan Wang <alanwang599@gmail.com>

github-actions · 2025-06-24T02:44:26Z

Coverage Report

Head Commit: 6e439ceb35dbc20d0532cdeb2fb086c2e29052f2

Base Commit: 1d81204095e1c8d830b07555028e6a2dee301799

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 82.40%

Status: PASSED ✅

Details

File	Status	Covered	Coverage	Missed Lines
cedar-policy-core/src/ast/expr.rs	🟢	1/1	100.00%
cedar-policy-core/src/ast/expr_visitor.rs	🔴	0/1	0.00%	58
cedar-policy-core/src/ast/name.rs	🔴	9/13	69.23%	317-319, 324
cedar-policy-core/src/ast/policy.rs	🟢	30/32	93.75%	1381, 1485
cedar-policy-core/src/est/policy_set.rs	🟢	5/5	100.00%
cedar-policy-core/src/est/scope_constraints.rs	🟡	35/48	72.92%	660, 672, 686, 715, 727, 741, 839, 841, 880-884
cedar-policy-core/src/evaluator.rs	🟢	3/3	100.00%
cedar-policy-core/src/parser/cst_to_ast.rs	🔴	0/1	0.00%	2131
cedar-policy-core/src/parser/cst_to_ast/to_ref_or_refs.rs	🟢	5/5	100.00%
cedar-policy-core/src/validator/rbac.rs	🔴	0/1	0.00%	405
cedar-policy-core/src/validator/typecheck.rs	🟢	1/1	100.00%
cedar-policy/src/api.rs	🟢	12/12	100.00%
cedar-policy/src/proto/policy.rs	🟢	2/2	100.00%

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 83.04%

Status: PASSED ✅

Details

Package	Status	Covered	Coverage	Base Coverage
cedar-language-server	🟢	4806/5522	87.03%	87.03%
cedar-policy	🔴	3280/4728	69.37%	69.36%
cedar-policy-cli	🔴	571/972	58.74%	58.74%
cedar-policy-core	🟢	21281/24889	85.50%	85.53%
cedar-policy-formatter	🟢	1070/1203	88.94%	88.94%
cedar-wasm	🔴	0/29	0.00%	0.00%

cdisselkoen

Looks good, just a couple minor comments.

I also wonder if we can write more tests for this functionality yet, or does that have to wait for a future PR that completes the CST-to-AST functionality?

cedar-policy-core/src/ast/name.rs

Signed-off-by: Alan Wang <alanwang599@gmail.com>

alanwang67 · 2025-06-24T14:42:51Z

Looks good, just a couple minor comments.

I also wonder if we can write more tests for this functionality yet, or does that have to wait for a future PR that completes the CST-to-AST functionality?

I think tests for the EST portion of the changes will need to wait until the CST-to-AST function is completed.

github-actions · 2025-06-24T14:58:16Z

Coverage Report

Head Commit: 0a9a0003e6c60bce8e68f50f3d57b35ba22e38c1

Base Commit: 1d81204095e1c8d830b07555028e6a2dee301799

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 81.75%

Status: PASSED ✅

Details

File	Status	Covered	Coverage	Missed Lines
cedar-policy-core/src/ast/expr.rs	🟢	1/1	100.00%
cedar-policy-core/src/ast/expr_visitor.rs	🔴	0/1	0.00%	58
cedar-policy-core/src/ast/name.rs	🔴	9/13	69.23%	317-319, 324
cedar-policy-core/src/ast/policy.rs	🟢	30/32	93.75%	1381, 1485
cedar-policy-core/src/est/policy_set.rs	🟢	5/5	100.00%
cedar-policy-core/src/est/scope_constraints.rs	🟡	44/60	73.33%	660, 672, 686, 715, 727, 741, 845, 847-850, 892-896
cedar-policy-core/src/evaluator.rs	🟢	3/3	100.00%
cedar-policy-core/src/parser/cst_to_ast.rs	🔴	0/1	0.00%	2131
cedar-policy-core/src/parser/cst_to_ast/to_ref_or_refs.rs	🟢	5/5	100.00%
cedar-policy-core/src/validator/rbac.rs	🔴	0/1	0.00%	405
cedar-policy-core/src/validator/typecheck.rs	🟢	1/1	100.00%
cedar-policy/src/api.rs	🟢	12/12	100.00%
cedar-policy/src/proto/policy.rs	🟢	2/2	100.00%

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 83.03%

Status: PASSED ✅

Details

Package	Status	Covered	Coverage	Base Coverage
cedar-language-server	🟢	4806/5522	87.03%	87.03%
cedar-policy	🔴	3280/4728	69.37%	69.36%
cedar-policy-cli	🔴	571/972	58.74%	58.74%
cedar-policy-core	🟢	21290/24901	85.50%	85.53%
cedar-policy-formatter	🟢	1070/1203	88.94%	88.94%
cedar-wasm	🔴	0/29	0.00%	0.00%

cedar-policy-core/src/ast/name.rs

cedar-policy-core/src/ast/policy.rs

Signed-off-by: Alan Wang <alanwang599@gmail.com>

github-actions · 2025-06-24T19:27:57Z

Coverage Report

Head Commit: 6dc4a832b24cadba4c4a81941217eafb4da7dbd7

Base Commit: 1d81204095e1c8d830b07555028e6a2dee301799

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 81.75%

Status: PASSED ✅

Details

File	Status	Covered	Coverage	Missed Lines
cedar-policy-core/src/ast/expr.rs	🟢	1/1	100.00%
cedar-policy-core/src/ast/expr_visitor.rs	🔴	0/1	0.00%	58
cedar-policy-core/src/ast/name.rs	🔴	9/13	69.23%	317-319, 324
cedar-policy-core/src/ast/policy.rs	🟢	30/32	93.75%	1381, 1485
cedar-policy-core/src/est/policy_set.rs	🟢	5/5	100.00%
cedar-policy-core/src/est/scope_constraints.rs	🟡	44/60	73.33%	660, 672, 686, 715, 727, 741, 845, 847-850, 892-896
cedar-policy-core/src/evaluator.rs	🟢	3/3	100.00%
cedar-policy-core/src/parser/cst_to_ast.rs	🔴	0/1	0.00%	2131
cedar-policy-core/src/parser/cst_to_ast/to_ref_or_refs.rs	🟢	5/5	100.00%
cedar-policy-core/src/validator/rbac.rs	🔴	0/1	0.00%	405
cedar-policy-core/src/validator/typecheck.rs	🟢	1/1	100.00%
cedar-policy/src/api.rs	🟢	12/12	100.00%
cedar-policy/src/proto/policy.rs	🟢	2/2	100.00%

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 83.03%

Status: PASSED ✅

Details

Package	Status	Covered	Coverage	Base Coverage
cedar-language-server	🟢	4806/5522	87.03%	87.03%
cedar-policy	🔴	3280/4728	69.37%	69.36%
cedar-policy-cli	🔴	571/972	58.74%	58.74%
cedar-policy-core	🟢	21290/24901	85.50%	85.53%
cedar-policy-formatter	🟢	1070/1203	88.94%	88.94%
cedar-wasm	🔴	0/29	0.00%	0.00%

…ized template annotations and values associated with generalized slots Signed-off-by: Alan Wang <alanwang599@gmail.com>

Signed-off-by: Alan Wang <alanwang599@gmail.com>

…e template Signed-off-by: Alan Wang <alanwang599@gmail.com>

…king for generalized_template_interp Signed-off-by: Alan Wang <alanwang599@gmail.com>

Signed-off-by: Alan Wang <alanwang599@gmail.com>

alanwang67 added 4 commits June 23, 2025 16:34

updated slot types and included id within entity reference

c5a7f04

Signed-off-by: Alan Wang <alanwang599@gmail.com>

make imports consistent

cf5f7a1

Signed-off-by: Alan Wang <alanwang599@gmail.com>

added comment

92db238

Signed-off-by: Alan Wang <alanwang599@gmail.com>

updates to proto policy.rs, currently doesn't account for generalized…

6e439ce

… slots in protobuf format Signed-off-by: Alan Wang <alanwang599@gmail.com>

cdisselkoen approved these changes Jun 24, 2025

View reviewed changes

cedar-policy-core/src/ast/name.rs Outdated Show resolved Hide resolved

cedar-policy-core/src/ast/name.rs Outdated Show resolved Hide resolved

added comments & edited function to return a pointer

0a9a000

Signed-off-by: Alan Wang <alanwang599@gmail.com>

john-h-kastner-aws reviewed Jun 24, 2025

View reviewed changes

cedar-policy-core/src/ast/name.rs Outdated Show resolved Hide resolved

cedar-policy-core/src/ast/policy.rs Outdated Show resolved Hide resolved

changed to using as_ref

6dc4a83

Signed-off-by: Alan Wang <alanwang599@gmail.com>

alanwang67 added 9 commits June 27, 2025 13:09

updates to Cedar's templates & policy structures to now store general…

687984e

…ized template annotations and values associated with generalized slots Signed-off-by: Alan Wang <alanwang599@gmail.com>

removed comment

ba8691f

Signed-off-by: Alan Wang <alanwang599@gmail.com>

clippy lint fixes

9878233

Signed-off-by: Alan Wang <alanwang599@gmail.com>

changed into to use from

381ed42

Signed-off-by: Alan Wang <alanwang599@gmail.com>

changed unwrap to expect

697df9b

Signed-off-by: Alan Wang <alanwang599@gmail.com>

generalized templates with schemas

b446dfd

updates to validator generalized slots annotation structure

620d0e2

fixed some feature flag errors & refactored typechecker

ff3a4bd

updates to protobuf formats

2863d73

alanwang67 changed the title ~~Updates for slot info~~ Cedar Generalized Templates Jul 9, 2025

alanwang67 added 8 commits July 9, 2025 13:14

Added test for typechecking of types that shadow primitive types

5aac5e5

fixed loop

ca8b85c

fixed test that failed because of schema change

d16a6e7

put back function that is used in cedar symcc

40c69e6

Signed-off-by: Alan Wang <alanwang599@gmail.com>

updates to remove generalized slots from appearing in the scope of th…

bcbec32

…e template Signed-off-by: Alan Wang <alanwang599@gmail.com>

added some more test cases for namespaces and included schema for lin…

9e2073e

…king for generalized_template_interp Signed-off-by: Alan Wang <alanwang599@gmail.com>

updates to error handling to reflect new changes

564a027

Signed-off-by: Alan Wang <alanwang599@gmail.com>

link time type checking updates

6880e82

Signed-off-by: Alan Wang <alanwang599@gmail.com>

alanwang67 closed this Aug 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cedar Generalized Templates#1669

Cedar Generalized Templates#1669
alanwang67 wants to merge 23 commits intocedar-policy:mainfrom
alanwang67:updates_for_slot_info

alanwang67 commented Jun 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

cdisselkoen left a comment

Uh oh!

Uh oh!

Uh oh!

alanwang67 commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alanwang67 commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Issue #, if available

Checklist for requesting a review

Uh oh!

github-actions bot commented Jun 24, 2025

Coverage Report

Coverage of Added or Modified Lines of Rust Code

Coverage of All Lines of Rust Code

Uh oh!

cdisselkoen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alanwang67 commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025

Coverage Report

Coverage of Added or Modified Lines of Rust Code

Coverage of All Lines of Rust Code

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2025

Coverage Report

Coverage of Added or Modified Lines of Rust Code

Coverage of All Lines of Rust Code

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alanwang67 commented Jun 23, 2025 •

edited

Loading