Remove ResourceUtils.CopyFolder and update comments#702
Merged
Conversation
Remove the public ResourceUtils.CopyFolder method to avoid duplication with the FS-layer implementation. Add a clarifying comment in SidecarHelper.Inspect explaining why the file is read directly (synchronous classification path and transient read failures are benign). Reword the comment on FileStorage.CopyFolderRecursive to clarify that it's an internal recursive copy used by the chokepoint so the FS layer controls the destination structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the public ResourceUtils.CopyFolder method to avoid duplication with the FS-layer implementation. Add a clarifying comment in SidecarHelper.Inspect explaining why the file is read directly (synchronous classification path and transient read failures are benign). Reword the comment on FileStorage.CopyFolderRecursive to clarify that it's an internal recursive copy used by the chokepoint so the FS layer controls the destination structure.