Skip to content

Fix(gencode): User warning raised as an exception #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fedorgrab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(gencode): User warning raised as an exception #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cellarium_schema/gencode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import gzip
import logging
import os
import warnings

from cellxgene_schema.gencode import GeneChecker, SupportedOrganisms
from cellxgene_schema.env import GENCODE_DIR as CZI_GENCODE_DIR
Expand Down Expand Up @@ -38,7 +39,7 @@ def __init__(self, species: SupportedOrganisms, gencode_version: int | None):
raise ValueError(f"gencode_version must be in [43, 44]: got {self.gencode_version}")
else:
if self.gencode_version is not None:
raise UserWarning("gencode_version is ignored if species is not HOMO_SAPIENS")
warnings.warn("gencode_version is ignored if species is not HOMO_SAPIENS", UserWarning)
file = self.GENE_FILES[species]
logger.info(f"using file {file}")

Expand Down