cmake: require Boost >= 1.90 (Boost.PFR get_name)#167
Merged
Conversation
The Godot binding (binding/godot/node.hpp) uses boost::pfr::get_name,
which was introduced in Boost.PFR in 1.88 and is absent from earlier
releases. Building against Boost 1.87 fails to compile the Godot back-end:
binding/godot/node.hpp:70: error:
'get_name' is not a member of 'boost::pfr'
Raising the minimum to 1.90 (per maintainer request) guarantees the
required Boost.PFR name-reflection API is present. Verified: with Boost
1.91 the previously-failing sherpa_tts_NODE_godot target compiles and
links cleanly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015Y1wf9JxscbkrSjJXH8oyd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Godot back-end (
binding/godot/node.hpp:70) callsboost::pfr::get_name<...>(). That API was added to Boost.PFR in 1.88 and is missing from earlier Boost. With the currentfind_package(Boost 1.87 …), building the Godot binding fails:(GCC's
did you mean 'avnd::get_name'?hint is a red herring — unrelated function.)Fix
Bump the minimum required Boost in
cmake/avendish.cmakefrom1.87to1.90, per @jcelerier's request, so the Boost.PFR name-reflection API is guaranteed present.Verification
Reproduced downstream in
sat-mtl/sherpa-pluginson Ubuntu 24.04. Building against Boost 1.87/1.83 fails as above; forcing Boost 1.91 makes the previously-failingsherpa_tts_NODE_godottarget compile and link cleanly (build/godot/sherpa_tts.so). The non-Godot targets were unaffected.🤖 Generated with Claude Code