emscripten: fix observer update() call (missing notify arg)#228
Merged
Conversation
observer_emscripten::update() gained a 'bool notify' parameter, but the devices_poll() call site still passed 2 args, breaking the wasm build (the emscripten backend is only compiled for wasm, so other CI never caught it). Poll detects hotplugged devices -> notify=true.
jcelerier
added a commit
to ossia/score
that referenced
this pull request
Jul 10, 2026
Pulls libossia with the bumped libremidi that fixes the emscripten observer update() call. ossia/libossia#907 -> celtera/libremidi#228.
Builds libremidi + the emscripten example with emsdk so the WebMIDI backend (backends/emscripten/*) is compiled on every PR. That backend is wasm-only, so no other CI job exercised it -- which is how the observer update() arg-count regression fixed in this PR slipped through.
jcelerier
pushed a commit
to ossia/libossia
that referenced
this pull request
Jul 11, 2026
Pulls the emscripten MIDI backend fix (observer update() notify arg) needed for the wasm build. See celtera/libremidi#228.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emscripten MIDI backend's
observer_emscripten::update()takes(inputs, outputs, bool notify), but thedevices_poll()call site inmidi_access.hppstill passed only 2 args:This breaks any wasm build (
too few arguments to function call). The emscripten backend is compiled only for wasm, so non-wasm CI never caught it.devices_poll()detects hotplugged devices →notify = true.Found while reviving the ossia/score wasm build (ossia/score#2034).
🤖 Generated with Claude Code