Improve error handling in check script - #1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
- Distinguish ENOENT from EACCES and other I/O errors instead of treating all failures as 'missing' - Log errors to stderr with descriptive messages - Validate JSON files parse correctly - Detect empty files - Report total failure count on exit Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
scripts/check.mjsfile had a barecatch {}that silently swallowed all errors — permission denied, encoding failures, and actual missing files were all reported identically as "missing". This made debugging impossible when a file existed but couldn't be read.Changes:
err.codeto distinguishENOENT(missing) fromEACCES(permission denied) from other I/O errors, logging the actualerr.messagefor non-trivial failuresstderrviaconsole.errorinstead ofstdout(success messages remain on stdout).json) are validated withJSON.parse; parse errors are surfaced with the specific parse failure messageprocess.exit(1)Link to Devin session: https://app.devin.ai/sessions/3d0fb42a2eba4bc0b3f67e75ff9b4334
Requested by: @cemphlvn