ci: include workflow files in pull_request path filters#198
Merged
Conversation
Adapter workflows only triggered on changes to their own adapter directory (and, for most, policies/**). PRs that modified only workflow files — e.g. renovate bumping the cerbos-setup-action pinned SHA — ran no test checks because the workflows weren't in their own paths filter. Also adds the missing policies/** filter to drizzle. Fixes #197 Signed-off-by: Alex Olivier <alex@alexolivier.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/*.yamlchanges, so renovate PRs that only bump pinned action SHAs (e.g. chore(deps): update cerbos/cerbos-setup-action digest to 53d0a0d #179) actually run tests*-publish.yamlto each adapter's filter so publish-workflow edits get exercised by the test workflow toopolicies/**filter fordrizzle.yaml(all other adapters already had it)Fixes #197
Test plan
.github/workflows/<adapter>.yamlpolicies/**or adapter source changes — if any adapter test runs unrelated to its workflow file, that's a surprise worth looking at